> On June 18, 2015, 10:47 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, > > line 447 > > <https://reviews.apache.org/r/35458/diff/3/?file=986790#file986790line447> > > > > This could result in checkstyle error. Can you run mvn clean install > > with latest patch and update?
Didn't find any checkstyle error. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.296s] [INFO] Lens .............................................. SUCCESS [16.872s] [INFO] Lens API .......................................... SUCCESS [40.549s] [INFO] Lens API for server and extensions ................ SUCCESS [40.032s] [INFO] Lens Cube ......................................... SUCCESS [6:01.126s] [INFO] Lens DB storage ................................... SUCCESS [39.162s] [INFO] Lens Query Library ................................ SUCCESS [35.682s] [INFO] Lens Hive Driver .................................. SUCCESS [12:37.331s] [INFO] Lens Driver for JDBC .............................. SUCCESS [1:34.918s] [INFO] Lens Server ....................................... SUCCESS [16:55.018s] [INFO] Lens client ....................................... SUCCESS [1:23.374s] [INFO] Lens CLI .......................................... SUCCESS [7:51.875s] [INFO] Lens Examples ..................................... SUCCESS [27.859s] [INFO] Lens Distribution ................................. SUCCESS [26.998s] [INFO] Lens ML Lib ....................................... SUCCESS [3:40.095s] [INFO] Lens ML Ext Distribution .......................... SUCCESS [11.858s] [INFO] Lens Regression ................................... SUCCESS [25.374s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 54:37.391s [INFO] Finished at: Thu Jun 18 17:05:27 IST 2015 [INFO] Final Memory: 173M/1650M - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35458/#review88358 ----------------------------------------------------------- On June 18, 2015, 9:56 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35458/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 9:56 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-603 > https://issues.apache.org/jira/browse/LENS-603 > > > Repository: lens > > > Description > ------- > > Check if projected column is expression and skip rewrite. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 9ba136f > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > aab7f31 > > Diff: https://reviews.apache.org/r/35458/diff/ > > > Testing > ------- > > Added unit test. mvn clean test is running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [10.186s] > [INFO] Lens .............................................. SUCCESS [0.331s] > [INFO] Lens API .......................................... SUCCESS [19.852s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.933s] > [INFO] Lens Cube ......................................... SUCCESS [4:27.262s] > [INFO] Lens DB storage ................................... SUCCESS [16.455s] > [INFO] Lens Query Library ................................ SUCCESS [8.453s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:28.647s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.158s] > [INFO] Lens Server ....................................... SUCCESS > [24:30.006s] > [INFO] Lens client ....................................... SUCCESS [49.657s] > [INFO] Lens CLI .......................................... SUCCESS [6:44.758s] > [INFO] Lens Examples ..................................... SUCCESS [5.254s] > [INFO] Lens Distribution ................................. SUCCESS [2.389s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:44.468s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [9.835s] > [INFO] Lens Regression ................................... SUCCESS [3.138s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 44:56.265s > [INFO] Finished at: Mon Jun 15 16:33:00 IST 2015 > [INFO] Final Memory: 146M/1433M > > > Thanks, > > Sushil Mohanty > >
