-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35595/
-----------------------------------------------------------

(Updated June 19, 2015, 6:43 p.m.)


Review request for lens.


Bugs: LENS-618
    https://issues.apache.org/jira/browse/LENS-618


Repository: lens


Description
-------

http://stackoverflow.com/questions/16365130/the-difference-between-usr-bin-env-bash-and-usr-bin-bash

This should explain the motivation. 

1. Not every distribution provides bash in `/bin/bash`
2. I don't think we are using any specific features of `sh`, so converted those 
to `bash` too.


Diffs (updated)
-----

  lens-dist/src/deb/control/server-control/postinst 
5d1f9766f8c9c8365fab7e3d41add4a3fc413120 
  lens-docker/lens-test/lens-bootstrap.sh 
3407dca6a1e132cbab8ac54757ccf2f9e8110bbc 
  lens-ml-lib/tools/scripts/lens-ml-classpath.sh 
7254b78474378b47541ff8283dade6e09c47ffbb 
  tools/conf-pseudo-distr/lens-env.sh 6a6222cfd137360a11748c8521256ee2dc85ce16 
  tools/scripts/build-docker.sh 31fbac252b2737a35dd7041d9a12ee2ddcef0293 
  tools/scripts/generate-site-public.sh 
75f86b0797718703de2a79bbe66b7169a18aa65c 
  tools/scripts/lens-cli 18695ef8edf8d3533fac08f110c990fe0f84b9b5 
  tools/scripts/lens-cli.sh e6eb34c7b0bfdae013c5b75ac079f5991479e657 
  tools/scripts/lens-config.sh b901fbb704eeb00a6d9885b3a4b0f02bed91f98b 
  tools/scripts/lens-ctl 13354691d998cb88f2e2b47a9aaf3fc2f05d99f1 
  tools/scripts/lens-run-class.sh ef64b03be83c7429a7ddf6349486c8f8f75dc8a9 
  tools/scripts/run-docker.sh 3372d43ab0fb9b0f6b43ff61f2eef5b263045283 
  tools/scripts/run-examples.sh 0e8af6a557ca9f4077cb88c867d3c39f8777e23e 

Diff: https://reviews.apache.org/r/35595/diff/


Testing
-------

Tested two of the scripts:

1. lens-ctl, which works as before. 
2. lens-cli.sh, which again, works as before

Testing on my box wouldn't show any improvements, only the distributions where 
location of bash is different thatn `/bin/bash`.


Thanks,

Rajat Khandelwal

Reply via email to