> On July 20, 2015, 3:45 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java, > > lines 819-823 > > <https://reviews.apache.org/r/36349/diff/6/?file=1016537#file1016537line819> > > > > Do we have tests around parsable and unparsable part spec code flow?
They do now. full spec is sent always and time + non time are sent additionally if possible. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36349/#review92248 ----------------------------------------------------------- On July 20, 2015, 5:37 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36349/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 5:37 p.m.) > > > Review request for lens. > > > Bugs: LENS-652 > https://issues.apache.org/jira/browse/LENS-652 > > > Repository: lens > > > Description > ------- > > Our Requirement is to be able to change path of an existing partition. > > > Diffs > ----- > > lens-api/pom.xml 507dd01a92671fe5b2be3f0a5156b24817691d7d > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 74b4e91e894ddc4995e2ddd36152ab97204294c0 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 6a9339365b7980d1db7f9c0f5bb8c414956611f8 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > bdb9c382fc0badfa19604aeeb329953b8919dc0b > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > a479c14d37f39b0a5fd95801a5d6b69e3f2037ff > lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java > 2de0cad507597e5c0dd58cd356e74dac6e3bca33 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > a87d0b7a1d5d4a89108e8a9c5718174b0e143531 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 13bfbd2469042cdb8751d54a670d4904af48c065 > lens-cli/src/test/resources/dim1-local-parts.xml > 87fbc6da94a1a7dfefb3474644bbd2992771e6ee > lens-cli/src/test/resources/fact1-local-parts.xml > 6201320787d481a5ef87459dad59ace1812e2abb > lens-client/src/main/java/org/apache/lens/client/LensClient.java > b15b024369b8b8b1229f8923f0c809936f10577f > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > b4e05524debaa747674014607a6047b9c3b3b63b > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > dc2d9f64e5c9ea2588e5a58814a82d75854bfdd7 > lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java > 8107f4c2f656a94246bf89f1d6e159bbeb9f32d3 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 8e2c9ed23670934a76d931ad6eb018bcf203dedf > > lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java > 1174d254a54539be7479bfa93363e65061bcd7c3 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > c7540420c19f54fdfe5139cecb581f1417351a4d > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > 7c966d8e61e04572ed2f3b851862b86b2d082612 > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java > 966dbdf606ff379c98af06b8c733b2be4d3ce692 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > ce6f43488a34f945842c7560f159870322136776 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 18b6c876abdf925b1c718b606377b72f90c4466b > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > f9398588fc3127708fe57960771c9b02296e93ab > lens-driver-hive/src/main/resources/hivedriver-default.xml > 85a3f89deba44a9ca5ef4ffd41074b1405d846b6 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 6226521545fc1dc478c41595c58a97e2f800f47a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > c5e1c14377b9ffe54e69a841559ab73df61ca162 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 811fd329141bb6f192c11df0bbde8fd4a89bbd3c > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > bfe4813b78ac98d45e0635d69c40ab6c5ae30fa0 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > dc1dc1d52a78cfc2e11ece5a0ef9b2c2ce251a7a > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java > e6d413252c1b74770e4f1cadd8ffa0423b400f11 > lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java > 1e2482809986d745e7767661d414d8d99a685142 > src/site/apt/admin/hivedriver-config.apt > b668e160f4fd1ce05179bb50c7dc6264ea6101e2 > src/site/apt/user/cli.apt 353c1717a94d8899e0e66afa69c8db4e78b46a3d > > Diff: https://reviews.apache.org/r/36349/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.054s] > [INFO] Lens .............................................. SUCCESS [3.398s] > [INFO] Lens API .......................................... SUCCESS [21.952s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.166s] > [INFO] Lens Cube ......................................... SUCCESS [4:08.672s] > [INFO] Lens DB storage ................................... SUCCESS [18.911s] > [INFO] Lens Query Library ................................ SUCCESS [16.230s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:47.532s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.907s] > [INFO] Lens Server ....................................... SUCCESS [5:27.831s] > [INFO] Lens client ....................................... SUCCESS [35.633s] > [INFO] Lens CLI .......................................... SUCCESS [2:47.536s] > [INFO] Lens Examples ..................................... SUCCESS [9.378s] > [INFO] Lens Distribution ................................. SUCCESS [11.749s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:25.497s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.054s] > [INFO] Lens Regression ................................... SUCCESS [11.638s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:45.976s > [INFO] Finished at: Mon Jul 20 11:10:37 UTC 2015 > [INFO] Final Memory: 193M/1771M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
