----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36393/#review92579 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On July 22, 2015, 10:28 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36393/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 10:28 a.m.) > > > Review request for lens. > > > Bugs: LENS-619 > https://issues.apache.org/jira/browse/LENS-619 > > > Repository: lens > > > Description > ------- > > LENS-619: Applying Query Launching Constraints before allowing a query to be > launched > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/Addable.java > 5a556918afcdb8967deee84472cd7863aeafc4fc > lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java > f594133e8a75603e5bb0c913d62ea189248cfa05 > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 539f0b0b0804257fae6b7ec0af8f2f715175d597 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 46e28a92353d31232f30cb21e1d46c4d4508404c > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > f7305fb288167cda088e263a62c77f264d779127 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 7c3e3e08bc7e6949588aa073665fd97596e1a1ae > lens-driver-hive/src/main/resources/hivedriver-default.xml > 300ce3fed7814d446b3aeb8688927c2dc8800f81 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > e3a879929ceb0dad054c71231bc4a70162ecd9ce > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > ebcdaca7c7bab3a15feb10e69ef41238a8bae506 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml > 99f6f205dfe6f1c16277ac6624106436df2b2b8f > lens-server-api/pom.xml b0b0fe017a239b24c3b9606b3be77a1722844e0f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 2b3a4800dc31e1c0787f2da9178456bec871a8a9 > > lens-server-api/src/main/java/org/apache/lens/server/api/common/ConfigBasedObjectCreationFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 52207d342ea9ea154ef6ebd1cf4266176039c561 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > a3fd6ac028cb45d8da605d2bfd79d0e60c676be9 > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71128b7d35e91fadf38a9c3926ce46d42369ead4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 80469275c6fda5bdc318edb699198be285a7990e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 7a2da9963375e38d72c5434a9b1f9fe5f10c12e2 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 6e7ab5dc1c78407a24e389c001ca3100563e3795 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > d72727e7832d02ed2ea90379cd29c7a8e509a8f8 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 5d7163f112d7c7115ebf8f012ba397bfee63adbc > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicy.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicyFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/EstimatedImmutableQueryCollection.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/WaitingQueriesSelectionPolicy.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/QueryLaunchingConstraint.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java > 7fa5cdb55959a44b52a29884fd629c2479fdfb96 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java > be7232134b59f7126edba569358389a9c26a5c74 > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > f9262994debe0b943123d13c58a22c10b2015e80 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > dffcfd3567dd015e7c79773c5e8cd6669c2d9d95 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/collect/DriverSpecificWaitingQueriesSelectionPolicyTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java > 0ab0b0ec7c83c1eac8d61c8a30ecec5e9dc2e322 > lens-server/pom.xml 6ac30a52cc8c1c58bf8e92bb77df358db6e22a3e > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 39f9f5216acf6e1be7cca6a0851152a78ba66176 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 63569d848d97ad1501cf1cb40f65df1e0938c49b > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelector.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/MutableQueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/QueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicy.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicyFactory.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/collect/WaitingQueriesSelector.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/constraint/QueryLaunchingConstraintsChecker.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraint.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraintFactory.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/util/FairPriorityBlockingQueue.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 0ee1c049c851568bb13bb43343e2b20d444d437a > lens-server/src/main/resources/lensserver-default.xml > d26beb77adf2c3660daa1efcd75ac4ccb3aeacf8 > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java > 75a5c0fb36dee53c9228b16f4ee77a3985d76b1e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7e486aee1e995954bd25beac85a9fafed95ce20e > > lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/IntersectingWaitingQueriesSelectorTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/ThreadSafetyTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/collect/UserSpecificWaitingQueriesSelectionPolicyTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsCheckerTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraintFactoryTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/constraint/TotalQueryCostCeilingConstraintTest.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml > 41c7eb62096673a4caccffd9f8c8e698ab663c36 > lens-server/src/test/resources/log4j.properties > 69ff32c3ee34b76c65110aeb7c828952188855ee > src/site/apt/admin/config.apt f8501905203c1a4aaee3f70e92a5f009526e787f > src/site/apt/admin/hivedriver-config.apt > 80a3028789348493a84e753965d32cc30690c503 > src/site/apt/admin/jdbcdriver-config.apt > b3d25f6751dd030a4ae818845a4a504ca41d7895 > > Diff: https://reviews.apache.org/r/36393/diff/ > > > Testing > ------- > > Testing done again. All test cases are passing now. > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.758s] > [INFO] Lens .............................................. SUCCESS [5.153s] > [INFO] Lens API .......................................... SUCCESS [41.771s] > [INFO] Lens API for server and extensions ................ SUCCESS [33.792s] > [INFO] Lens Cube ......................................... SUCCESS [6:15.079s] > [INFO] Lens DB storage ................................... SUCCESS [32.129s] > [INFO] Lens Query Library ................................ SUCCESS [23.212s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:41.837s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [47.076s] > [INFO] Lens Server ....................................... SUCCESS > [16:04.057s] > [INFO] Lens client ....................................... SUCCESS [48.693s] > [INFO] Lens CLI .......................................... SUCCESS [4:54.034s] > [INFO] Lens Examples ..................................... SUCCESS [17.629s] > [INFO] Lens Distribution ................................. SUCCESS [13.324s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:25.801s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.223s] > [INFO] Lens Regression ................................... SUCCESS [17.430s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:12.306s > [INFO] Finished at: Wed Jul 22 15:40:24 IST 2015 > [INFO] Final Memory: 123M/344M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >