> On July 22, 2015, 3:28 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, lines > > 228-230 > > <https://reviews.apache.org/r/36686/diff/1/?file=1018482#file1018482line228> > > > > This code can be removed now I guess.
If not, please add the `break` statement - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36686/#review92568 ----------------------------------------------------------- On July 22, 2015, 2:21 p.m., sharad agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36686/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 2:21 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-251 Support for stores with continuous update period > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd > ab7d3ff8dc0b398ebbb554c5caa6916b5c0a9078 > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java > 253323b47bd5b8d05d826960f4d91198f6f90ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > 9931e7cd1bb7b3553eb22ce61386202b883c98e6 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 373c80a5fdf8a3c5607d1ca83d59bbb9610fe780 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > e0338f5abd3f17938a78595211805230249b79db > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > e04d04cb7383492158531e8f920dde63320498b5 > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 7ecabfacb3f3f6047b65fb86f80fcdd9c011cd61 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > dee43ef026bc44d315f489c98f4e69c13682470c > lens-examples/src/main/resources/cube-queries.sql > 7668f54fbaf1d75425cb18052fcee1e3e1e3d205 > lens-examples/src/main/resources/db-storage-schema.sql > bbb62e8f32353cab6188da158bbad90f291823bc > lens-examples/src/main/resources/sales-aggr-continuous-fact.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/36686/diff/ > > > Testing > ------- > > Added the unit test to TestCubeRewriter. > > Also created sales_aggr_continuous_fact in examples and tested on lens shell: > > lens-shell>cube select store_sales from sales where time_range_in(order_time, > 'now.second-2 days', 'now.second') > Command 'cube select store_sales from sales where time_range_in(order_time, > 'now.second-2 days', 'now.second')' not found (for assistance press TAB) > lens-shell>query execute cube select store_sales from sales where > time_range_in(order_time, 'now.second-2 days', 'now.second') > 22 Jul 2015 08:45:29,932 [Spring Shell] INFO cliLogger - Query handle: > 71714696-0a06-46ad-9550-c52c1af32957 > 22 Jul 2015 08:45:35,975 [Spring Shell] INFO cliLogger - User query: 'cube > select store_sales from sales where time_range_in(order_time, 'now.second-2 > days', 'now.second')' was submitted to org.apache.lens.driver.jdbc.JDBCDriver > 22 Jul 2015 08:45:35,976 [Spring Shell] INFO cliLogger - Driver query: > 'SELECT sum(( sales . store_sales )) FROM mydb_sales_aggr_continuous_fact > sales WHERE ((( sales . order_time ) between '2015-07-20 08:45:30' and > '2015-07-22 08:45:30' ))' and Driver handle: null > 22 Jul 2015 08:45:36,095 [Spring Shell] INFO cliLogger - > RUNNING:71714696-0a06-46ad-9550-c52c1af32957 is running - Progress:0.0:null > 22 Jul 2015 08:45:36,246 [Spring Shell] INFO cliLogger - > RUNNING:71714696-0a06-46ad-9550-c52c1af32957 is running - Progress:0.0:null > 22 Jul 2015 08:45:36,467 [Spring Shell] INFO cliLogger - > RUNNING:71714696-0a06-46ad-9550-c52c1af32957 is running - Progress:0.0:null > 22 Jul 2015 08:45:36,594 [Spring Shell] INFO cliLogger - > RUNNING:71714696-0a06-46ad-9550-c52c1af32957 is running - Progress:0.0:null > 22 Jul 2015 08:45:36,709 [Spring Shell] INFO cliLogger - > RUNNING:71714696-0a06-46ad-9550-c52c1af32957 is running - Progress:0.0:null > 22 Jul 2015 08:45:36,824 [Spring Shell] INFO cliLogger - SUCCESSFUL:Query > is successful! - Result Available > C1 > 8.0 > 1 rows process in (6) seconds. > > > Thanks, > > sharad agarwal > >
