> On July 17, 2015, 4:41 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java, > > lines 29-38 > > <https://reviews.apache.org/r/35590/diff/4/?file=1013139#file1013139line29> > > > > I see all HealthCheck are doing the same code. Can we create > > LensServiceHealthCheck super class and pass Service instance from all > > subclasses? > > Yash Sharma wrote: > In our case all the services do not share a common superclass. Have moved > the code to utility class for reuse. Extending from superclass and > HealthCheck would also complicate design. Let me know if new changes looks > good. > > Amareshwari Sriramadasu wrote: > Looks fine.
Great. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review92023 ----------------------------------------------------------- On July 22, 2015, 6 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 6 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/health/HealthCheckable.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java > PRE-CREATION > lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 74cc00c > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > bd31f82 > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 72fe455 > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 5855ac6 > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > lens-server/src/main/java/org/apache/lens/server/LensServiceImpl.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96 > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 646de8c > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 2455232 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9e5fcd5 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 3a8fc95 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > a5033fe > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > a84fcd3 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > PRE-CREATION > src/site/apt/user/cli.apt 63f2b3f > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.070 > s] > [INFO] Lens ............................................... SUCCESS [ 5.328 > s] > [INFO] Lens API ........................................... SUCCESS [ 21.978 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 26.296 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:52 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 20.124 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 15.063 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:39 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.737 > s] > [INFO] Lens Server ........................................ SUCCESS [05:30 > min] > [INFO] Lens client ........................................ SUCCESS [ 45.113 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:45 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 13.261 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 9.223 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:25 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.725 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.116 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:45 min > [INFO] Finished at: 2015-07-22T23:18:19+05:30 > [INFO] Final Memory: 131M/369M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
