----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36726/#review92751 -----------------------------------------------------------
Ship it! Fix it and Ship it lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java (line 45) <https://reviews.apache.org/r/36726/#comment146993> Can we rewrite this log with {} placeholders? - Raju Bairishetti On July 23, 2015, 11:26 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36726/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 11:26 a.m.) > > > Review request for lens and Raju Bairishetti. > > > Bugs: LENS-665 > https://issues.apache.org/jira/browse/LENS-665 > > > Repository: lens > > > Description > ------- > > All occurrences of commons.logging and log4j are replaced > > > Diffs > ----- > > lens-cube/pom.xml 56d7f10 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java > 29f6c02 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 9384021 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > ebbb8b6 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java d9af602 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java > 47a30dd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > c8abca0 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java > 9cba3a7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 4ede3db > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > edf0f74 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 86c420b > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > f861ec7 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 39b13cc > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9931e7c > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 075cdb4 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 63aaa12 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 9a2a44a > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > 4bd89a7 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 3201c09 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 97c7a46 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 6e4e948 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java > b4c603b > > lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java > fc06f08 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 9a92bee > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 0228fb8 > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > 76f976a > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > 6f6d2e4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 9d1d9f2 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 373c80a > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 04a13a6 > > Diff: https://reviews.apache.org/r/36726/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.361s] > [INFO] Lens .............................................. SUCCESS [2.826s] > [INFO] Lens API .......................................... SUCCESS [22.762s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.089s] > [INFO] Lens Cube ......................................... SUCCESS [4:13.833s] > [INFO] Lens DB storage ................................... SUCCESS [19.248s] > [INFO] Lens Query Library ................................ SUCCESS [14.539s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:47.412s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.151s] > [INFO] Lens Server ....................................... SUCCESS [5:26.781s] > [INFO] Lens client ....................................... SUCCESS [37.188s] > [INFO] Lens CLI .......................................... SUCCESS [2:36.862s] > [INFO] Lens Examples ..................................... SUCCESS [9.105s] > [INFO] Lens Distribution ................................. SUCCESS [8.047s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:23.407s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s] > [INFO] Lens Regression ................................... SUCCESS [10.964s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:35.424s > [INFO] Finished at: Thu Jul 23 11:23:53 UTC 2015 > [INFO] Final Memory: 193M/2120M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
