> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line
> > 851
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022478#file1022478line851>
> >
> > I believe it would be more explicit if we make sub classes of
> > LensException just like
> >
> > ```
> > public class FieldsCannotBeQueriedTogetherException extends
> > LensException {
> > ```
> >
> > Then the javadoc of most of the methods would become clear. The
> > `@throws` field can be explicit as to why it throws an exception.
Just be careful that subclassing should not result in one exception sub class
per error code. Otherwise it might become unmaintainable. A subclass is only
required if getFormattedErrorMessage is complex (e.g. created using some logic
on error payload) OR a error payload has to be transferred. The problem of
enhanced documentation can be solved with @throws LensException with {@link
org.apache.lens.cube.error.LensCubeErrorCode.NO_JOIN_PATH}
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------
On July 27, 2015, 3:54 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 3:54 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
>
>
> Bugs: LENS-187
> https://issues.apache.org/jira/browse/LENS-187
>
>
> Repository: lens
>
>
> Description
> -------
>
> Moved all cube related error messages from (InMobi) Hive to Lens.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 6130ad7
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java
> 0006b22
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
> d5276e0
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java
> f880495
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java
> 9309307
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
> 6c85c2d
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
> 6c88fb3
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
> 50a4d53
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java
> 2ff5959
> lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java
> feb26d7
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
> 65c240a
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
> 72dc64b
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java
> 68bffed
> lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
> 4a95d5a
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java
> 3814cf6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java
> 922501d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
> 895cb06
> lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java
> 623c58b
> lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java
> 03377dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java
> 35011e8
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java
> 7d04d19
> lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java
> b5f5adc
> lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java
> f3f3f78
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java
> b63111b
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
> 4ad2f1f
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
> 7bfbd86
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java
> 12acf98
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
> 820d77d
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java
> e6ed86b
>
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
> 0268bbf
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
> e0338f5
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
> 501a4b0
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java
> 13058e2
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
> f65bd28
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
> e04d04c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
> 6717b5b
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
> 901b95e
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
> 7f872e9
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
> ed08605
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
> d16f6a5
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java
> 0805fb5
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
> 26836fe
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java
> f2d7990
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
> 453a102
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
> 0e22ce2
>
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
> 123b6ee
>
> lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java
> 4ab26ec
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java
> 9628865
>
> Diff: https://reviews.apache.org/r/36850/diff/
>
>
> Testing
> -------
>
> All unit tests are running fine.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS
> [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS
> [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO]
> ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
