----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36884/#review93276 -----------------------------------------------------------
Ship it! Seems okay. lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 444) <https://reviews.apache.org/r/36884/#comment147653> I think this can be omitted. http://stackoverflow.com/a/29561054 - Rajat Khandelwal On July 28, 2015, 5:02 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36884/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 5:02 p.m.) > > > Review request for lens. > > > Bugs: LENS-426 > https://issues.apache.org/jira/browse/LENS-426 > > > Repository: lens > > > Description > ------- > > Have gone through all the code flow of estimate. Changes include : > > - Changing some logs to debug; put isDebugEnabled check for doing costly > computation on params > - Have moved to parameterized logging wherever it is not > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 65c240a > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 895cb06 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 5fb2441 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 820d77d > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1316257 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > 52edffc > > Diff: https://reviews.apache.org/r/36884/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.069s] > [INFO] Lens .............................................. SUCCESS [3.084s] > [INFO] Lens API .......................................... SUCCESS [21.467s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.744s] > [INFO] Lens Cube ......................................... SUCCESS [6:02.161s] > [INFO] Lens DB storage ................................... SUCCESS [18.850s] > [INFO] Lens Query Library ................................ SUCCESS [15.269s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:45.689s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.300s] > [INFO] Lens Server ....................................... SUCCESS [5:22.277s] > [INFO] Lens client ....................................... SUCCESS [33.811s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.257s] > [INFO] Lens Examples ..................................... SUCCESS [8.561s] > [INFO] Lens Distribution ................................. SUCCESS [8.048s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.468s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.727s] > [INFO] Lens Regression ................................... SUCCESS [10.513s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:06.336s > [INFO] Finished at: Tue Jul 28 11:17:44 UTC 2015 > [INFO] Final Memory: 175M/1186M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
