> On July 30, 2015, 12:11 p.m., Amareshwari Sriramadasu wrote: > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, > > line 71 > > <https://reviews.apache.org/r/36133/diff/2/?file=1023412#file1023412line71> > > > > Is this not breaking local setup and tests?
No, it won't break. The table would get created even in local setup. I have just moved the statements in createTable method to createFinishedQueriesTable(). There were just two statements in createTable() and the method was called by createFinishedQueriesTable() method only. The createTable() was not offering reusability. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36133/#review93576 ----------------------------------------------------------- On July 28, 2015, 6:58 a.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36133/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 6:58 a.m.) > > > Review request for lens, Jaideep dhok and Pranav Agarwal. > > > Bugs: LENS-639 > https://issues.apache.org/jira/browse/LENS-639 > > > Repository: lens > > > Description > ------- > > Patch for LENS-639. All database updates will be handled by commits & > rollbacks. > > > Diffs > ----- > > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 1904350 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 9c386a6 > > Diff: https://reviews.apache.org/r/36133/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Deepak Barr > >
