----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36981/#review93885 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (lines 40 - 54) <https://reviews.apache.org/r/36981/#comment148303> unnecessary line breaks in between. lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 282) <https://reviews.apache.org/r/36981/#comment148304> else block Can be removed - Rajat Khandelwal On July 31, 2015, 3:15 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36981/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 3:15 p.m.) > > > Review request for lens. > > > Bugs: LENS-666 > https://issues.apache.org/jira/browse/LENS-666 > > > Repository: lens > > > Description > ------- > > Changes include : > - Remove log4j dependency > - Move existing log4j.propertise to logback.xml > - CLI verbose/debug logger moved to logback > - Move QueryExecutionStat loggers to logback > > Pending : > - Remove transitive log4j dependencies > - update licenses wrt logback > > > Diffs > ----- > > lens-api/pom.xml e1b763d > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > c059f30 > lens-client/pom.xml d83f830 > lens-cube/pom.xml 36b508a > lens-cube/src/test/resources/log4j.properties deaf1e1 > lens-cube/src/test/resources/logback.xml PRE-CREATION > lens-driver-hive/src/test/resources/log4j.properties 2c2dc45 > lens-driver-hive/src/test/resources/logback.xml PRE-CREATION > lens-driver-jdbc/pom.xml 2cb7f58 > lens-query-lib/src/test/resources/log4j.properties a69d13a > lens-query-lib/src/test/resources/logback.xml PRE-CREATION > lens-server-api/pom.xml 6822976 > lens-server/pom.xml 5174607 > > lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java > 0945a35 > > lens-server/src/main/java/org/apache/lens/server/stats/event/LoggableLensStatistics.java > e8a7b0c > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java > 4144416 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogLayout.java > 67a163c > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java > 9ff878c > lens-server/src/main/resources/lensserver-default.xml 6af8d10 > lens-server/src/main/webapp/WEB-INF/log4j.properties f5fdffa > lens-server/src/main/webapp/WEB-INF/web.xml 4ee54a6 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > 3573a1e > > lens-server/src/test/java/org/apache/lens/server/stats/TestLogStatisticsStore.java > c8a0ea5 > > lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java > 819c62a > lens-server/src/test/resources/log4j.properties 9cc1e36 > lens-server/src/test/resources/logback.xml PRE-CREATION > pom.xml 3c98077 > src/site/apt/admin/config.apt 2e1dbe7 > src/site/apt/admin/monitoring.apt 3ad2f92 > src/site/apt/lenshome/install-and-run.apt 8016491 > tools/conf-pseudo-distr/client/log4j.properties 3756cf7 > tools/conf-pseudo-distr/client/logback.xml PRE-CREATION > tools/conf-pseudo-distr/server/log4j.properties 2b04ea5 > tools/conf-pseudo-distr/server/logback.xml PRE-CREATION > tools/conf/client/log4j.properties 3756cf7 > tools/conf/client/logback.xml PRE-CREATION > tools/conf/server/log4j.properties 2b04ea5 > tools/conf/server/logback.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/36981/diff/ > > > Testing > ------- > > Tested query log fetching > Tested query execution statistics > Tested debug/verbose logging > > Pending all tests. > > > Thanks, > > Amareshwari Sriramadasu > >
