----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review94068 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 120) <https://reviews.apache.org/r/36178/#comment148568> Remove commented code. lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (lines 184 - 185) <https://reviews.apache.org/r/36178/#comment148569> Can we safely assume it'll never be null? The non null check can be added in client's constructor at the end. use `Preconditions.checkArgument` for valid state creation. lens-client/src/main/java/org/apache/lens/client/LensClient.java (line 237) <https://reviews.apache.org/r/36178/#comment148571> Since this is the only place `pathValidator` is being created, And going up the call heirarchy, all constructors come here, and `pathValidator` has no setters, it's 100% sure that at this point, pathValidator is null. - Rajat Khandelwal On Aug. 4, 2015, 8:18 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 8:18 p.m.) > > > Review request for lens. > > > Bugs: LENS-634 > https://issues.apache.org/jira/browse/LENS-634 > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431 > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > PRE-CREATION > lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > bdfae24 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > c059f30 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5fd80a1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 5493dba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > c505680 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 56e962d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > fa342c8 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 319077a > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > da11069 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ae6d682 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > src/site/apt/user/cli.apt 5dd0bfb > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 > s] > [INFO] Lens ............................................... SUCCESS [ 3.106 > s] > [INFO] Lens API ........................................... SUCCESS [ 25.443 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 > s] > [INFO] Lens Cube .......................................... SUCCESS [05:09 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.055 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.572 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:31 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 > s] > [INFO] Lens Server ........................................ SUCCESS [05:05 > min] > [INFO] Lens client ........................................ SUCCESS [ 34.200 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:03 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.993 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.751 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:13 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.198 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:30 min > [INFO] Finished at: 2015-08-04T20:07:56+05:30 > [INFO] Final Memory: 132M/375M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
