> On Aug. 3, 2015, 8:04 a.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java, line > > 178 > > <https://reviews.apache.org/r/36984/diff/1/?file=1026086#file1026086line178> > > > > Is this change needed? > > Himanshu Gahlaut wrote: > Yes > > Rajat Khandelwal wrote: > Why?
There is no table named as "table". Posting "select name from table" will result in rewrite failure. This test needs the query to be accepted and an handle to be returned for it. Earlier a handle was returned as there was no early rewrite and select. Going forward a handle will only be returned if rewrite and select is successful, hence the query has to be modified such that it can be successfully rewritten. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36984/#review93874 ----------------------------------------------------------- On Aug. 4, 2015, 6:04 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36984/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 6:04 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-700: Addressed code review comments > > > LENS-700: Fixing test cases after addition of failing driver > > > Diffs > ----- > > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > ea2433636282d0e6fdfabfb34c4421e68a125291 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 28ff92059b0c3040dcb54811c39a59bf684c0f6b > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > b5235ad5a799cb54c27bb2449478c4e9ef593bc0 > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 80e29ba114dbde97ab932027c7946315cdafb9c6 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 91e908139ca556d8611dff9eb109d9620a513352 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > f1461bc2bd2c89836c26fd3445988009b25c6b18 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 4b9962a9cda22002cdc4826ebce3db4c77216223 > lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION > lens-server/src/test/resources/lens-site.xml > bd9382820d59ecdc075d1f9b7258e31f899ca6d5 > > Diff: https://reviews.apache.org/r/36984/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s] > [INFO] Lens .............................................. SUCCESS [10.947s] > [INFO] Lens API .......................................... SUCCESS [36.928s] > [INFO] Lens API for server and extensions ................ SUCCESS [30.843s] > [INFO] Lens Cube ......................................... SUCCESS [8:08.461s] > [INFO] Lens DB storage ................................... SUCCESS [44.141s] > [INFO] Lens Query Library ................................ SUCCESS [35.886s] > [INFO] Lens Hive Driver .................................. SUCCESS > [12:52.309s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s] > [INFO] Lens Server ....................................... SUCCESS > [18:21.693s] > [INFO] Lens client ....................................... SUCCESS [1:06.921s] > [INFO] Lens CLI .......................................... SUCCESS [8:41.236s] > [INFO] Lens Examples ..................................... SUCCESS [14.389s] > [INFO] Lens Distribution ................................. SUCCESS [15.593s] > [INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s] > [INFO] Lens Regression ................................... SUCCESS [16.175s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 58:05.001s > [INFO] Finished at: Tue Aug 04 23:26:47 IST 2015 > [INFO] Final Memory: 124M/407M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
