> On Aug. 10, 2015, 2:05 a.m., Raju Bairishetti wrote: > > Can we use **Test** prefix for test class name instead of **Test** as > > suffix (QueryContextPriorityComparator**Test**.java)?
I try to follow TestNg's approach to naming Test classes. https://github.com/cbeust/testng/blob/master/src/test/java/org/testng/internal/invokers/InvokedMethodListenerSubtypeTest.java https://github.com/cbeust/testng/blob/master/src/test/java/org/testng/internal/UtilsTest.java https://github.com/cbeust/testng/blob/master/src/test/java/org/testng/AssertTest.java - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37253/#review94694 ----------------------------------------------------------- On Aug. 8, 2015, 2:47 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37253/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 2:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-631 > https://issues.apache.org/jira/browse/LENS-631 > > > Repository: lens > > > Description > ------- > > LENS-631: Using Query Cost instead of priority field for comparing queries in > priority blocking queue > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 86e3fa359bcd8bef331545a161867421f6760321 > > lens-server/src/main/java/org/apache/lens/server/query/QueryContextPriorityComparator.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2983db418e1361715b79a85426661b64565a45c0 > > lens-server/src/main/java/org/apache/lens/server/util/FairPriorityBlockingQueue.java > 1175f651de5178137bb3a64733bfa8a7d351fe1b > > lens-server/src/test/java/org/apache/lens/server/query/QueryContextPriorityComparatorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37253/diff/ > > > Testing > ------- > > All test cases passed. > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.547s] > [INFO] Lens .............................................. SUCCESS [5.890s] > [INFO] Lens API .......................................... SUCCESS [39.218s] > [INFO] Lens API for server and extensions ................ SUCCESS [31.762s] > [INFO] Lens Cube ......................................... SUCCESS [8:40.665s] > [INFO] Lens DB storage ................................... SUCCESS [45.425s] > [INFO] Lens Query Library ................................ SUCCESS [37.423s] > [INFO] Lens Hive Driver .................................. SUCCESS > [13:06.858s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [1:03.956s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [25.479s] > [INFO] Lens Server ....................................... SUCCESS > [18:33.572s] > [INFO] Lens client ....................................... SUCCESS [1:14.496s] > [INFO] Lens CLI .......................................... SUCCESS [8:39.458s] > [INFO] Lens Examples ..................................... SUCCESS [14.892s] > [INFO] Lens Distribution ................................. SUCCESS [12.944s] > [INFO] Lens ML Lib ....................................... SUCCESS [4:09.984s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.043s] > [INFO] Lens Regression ................................... SUCCESS [19.155s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 59:31.761s > [INFO] Finished at: Sat Aug 08 20:11:32 IST 2015 > [INFO] Final Memory: 126M/404M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
