----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37293/#review94724 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 271) <https://reviews.apache.org/r/37293/#comment149340> Shoould we throw LensException here? LENS-187 will remove all SemanticExceptions. lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (lines 1389 - 1395) <https://reviews.apache.org/r/37293/#comment149341> Commented code - Rajat Khandelwal On Aug. 10, 2015, 4:52 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37293/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 4:52 p.m.) > > > Review request for lens. > > > Bugs: LENS-711 > https://issues.apache.org/jira/browse/LENS-711 > > > Repository: lens > > > Description > ------- > > Changes include : > - Add ability to specify multiple chain columns > - Add rewriter capability to understand multiple chains for a column > - Rewriter tests added > - End to end test in lens-cli > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd e6cb87d > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 9912eef > lens-cli/src/test/resources/sample-cube.xml f0eba57 > lens-cli/src/test/resources/test-detail.xml PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 742c6a0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 50a4d53 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 4a95d5a > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > 03377dd > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 7d04d19 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 077396e > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 1d4e7dd > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > f65bd28 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 7d9183c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > 00d92b5 > lens-examples/src/main/resources/sales-cube.xml 4923aa3 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 70bd20d > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6e3afc6 > > Diff: https://reviews.apache.org/r/37293/diff/ > > > Testing > ------- > > Verified examples > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s] > [INFO] Lens .............................................. SUCCESS [3.083s] > [INFO] Lens API .......................................... SUCCESS [21.917s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.881s] > [INFO] Lens Cube ......................................... SUCCESS [6:14.198s] > [INFO] Lens DB storage ................................... SUCCESS [20.475s] > [INFO] Lens Query Library ................................ SUCCESS [15.247s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s] > [INFO] Lens Server ....................................... SUCCESS [5:41.025s] > [INFO] Lens client ....................................... SUCCESS [37.324s] > [INFO] Lens CLI .......................................... SUCCESS [2:33.561s] > [INFO] Lens Examples ..................................... SUCCESS [9.115s] > [INFO] Lens Distribution ................................. SUCCESS [8.490s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s] > [INFO] Lens Regression ................................... SUCCESS [10.622s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:04.962s > [INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015 > [INFO] Final Memory: 204M/2499M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
