----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37346/#review95072 -----------------------------------------------------------
Overall changes look fine. Can you include unit tests for new functionality added in email notifier? lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 200) <https://reviews.apache.org/r/37346/#comment149889> What are the causes of LensException here ? Should we cath Throwable here ? - Amareshwari Sriramadasu On Aug. 12, 2015, 9:56 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37346/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 9:56 a.m.) > > > Review request for lens. > > > Bugs: LENS-693 > https://issues.apache.org/jira/browse/LENS-693 > > > Repository: lens > > > Description > ------- > > Query Result Mail is not working when finished queries is set to zero as the > queries are immediately going to the DB > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java > 6a9f4558afc3a8430b43dcc65d73c813575a334d > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 7a5b177538e4a8c946422ff905c6c048d828b6ab > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 31c343a7b72c13ff9eb9b01038574297629e381b > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 78b3320977f9b46b2719ba80190fa77e87ecc729 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 3b761268645acf150d149e51f69521bf164c61ee > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c29a1ac4be7c44c13e3d1e964b18c240adb61d5f > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > af42eb06e2c030a7040b970e982cab782b2bb251 > > Diff: https://reviews.apache.org/r/37346/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
