----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37402/#review95244 -----------------------------------------------------------
lens-driver-jdbc/pom.xml (lines 112 - 131) <https://reviews.apache.org/r/37402/#comment150098> Why are all these dependencies required? lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java (line 106) <https://reviews.apache.org/r/37402/#comment150099> We should be using existing jdbc url spec itself, instead of new. lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/drill/DrillConnection.java (line 34) <https://reviews.apache.org/r/37402/#comment150100> We shouldnt require a separate connection. DB Connection pool should work. - Amareshwari Sriramadasu On Aug. 12, 2015, 5:30 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37402/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 5:30 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Initial patch for testing Drill Jdbc with Lens. > > > Diffs > ----- > > lens-cli/pom.xml 7bd2be9 > lens-client/pom.xml ce9c68e > lens-driver-jdbc/pom.xml d5f4ebe > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > a26acde > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/drill/DrillConnection.java > PRE-CREATION > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDrillJdbcDriver.java > PRE-CREATION > lens-server/pom.xml de9a360 > pom.xml 7353b42 > > Diff: https://reviews.apache.org/r/37402/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
