> On Aug. 17, 2015, 9:33 a.m., Raju Bairishetti wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 158 > > <https://reviews.apache.org/r/37522/diff/1/?file=1041728#file1041728line158> > > > > Do we need to check whether numOfDistinctValues is **present** or not?
Not requried for equals. Optional.equals takes care. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37522/#review95575 ----------------------------------------------------------- On Aug. 17, 2015, 9:01 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37522/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 9:01 a.m.) > > > Review request for lens. > > > Bugs: LENS-731 > https://issues.apache.org/jira/browse/LENS-731 > > > Repository: lens > > > Description > ------- > > Changes include : > - Cube xsd update > - Removed InlineDimAttribute class and moved values to BaseDimAttribute > directly. Inline values can be provided for any attribute - even ref > attribute. > - Added tests > - Updated examples > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 02ea2d1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 3a7c29a > lens-cli/src/test/resources/test-dimension.xml a9b7c08 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > f5a84d8 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > e8d2fae > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5d66039 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > ae8984f > lens-examples/src/main/resources/customer.xml 1b4f854 > lens-examples/src/main/resources/sales-cube.xml 2d67f5c > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > d6c4f17 > > Diff: https://reviews.apache.org/r/37522/diff/ > > > Testing > ------- > > Verified examples > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.450s] > [INFO] Lens .............................................. SUCCESS [2.825s] > [INFO] Lens API .......................................... SUCCESS [22.038s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.225s] > [INFO] Lens Cube ......................................... SUCCESS [5:03.657s] > [INFO] Lens DB storage ................................... SUCCESS [19.686s] > [INFO] Lens Query Library ................................ SUCCESS [14.373s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.480s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [38.549s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.230s] > [INFO] Lens Server ....................................... SUCCESS [5:41.728s] > [INFO] Lens client ....................................... SUCCESS [37.502s] > [INFO] Lens CLI .......................................... SUCCESS [2:36.386s] > [INFO] Lens Examples ..................................... SUCCESS [8.514s] > [INFO] Lens Distribution ................................. SUCCESS [8.730s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:18.799s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.927s] > [INFO] Lens Regression ................................... SUCCESS [11.196s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:53.269s > [INFO] Finished at: Mon Aug 17 08:58:13 UTC 2015 > [INFO] Final Memory: 177M/1131M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
