J. Wolfgang Kaltz wrote:
[...]
I checked in the above-mentioned changes. I noticed we now have several places where we have code like
String someUri = "lenya://lenya/pubs/" + pubId + ...
see FIXME note at DocumentTypeBuilderImpl::197
I guess we should encapsulate that somewhere ? How about Publication.getUri() ?
+1
Maybe we should include the notion of "source" in the method name to avoid confusion with the (browser) URI (like /lenya/default).
Maybe just Publication.getSourceURI() ?
OK, done
Note that the document creation itself still uses java.io.File
But anyway as discussed we want to refactor document creation code, probably into DocumentManager.add() as you suggested
Maybe that method should also have metadata as parameters, to ensure (or at least suggest to callers) that metadata will always be created ? Currently blog entries do not have metadata.
Once that is done, we can start getting rid of DocumentTypeResolver and associates.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
