J. Wolfgang Kaltz wrote:(...)+ + 1. The {{{Create}}} usecase handler
+ 1. builds the {{{Document}}} object using the {{{DocumentIdentityMap}}}
Maybe we can delegate that to DocumentManager.add() as well, which would return the instance when done
OK, that would be possible. But it is not unclean to work with
Document objects which are not represented by "real" documents
(XML, sitetree entry etc.).
I agree in principle; but I am not sure our current Document object is still suited in this regard: it has getResourceType() and getSourceURI(), which are highly useful, but only make sense once the document has actually been created.
Note that only the implementation of ParentChildCreatorInterface "knows" how to construct a URI for a document; it is not the same for default publication and blog publication.
I'm currently removing the usage of File in document creation, so that has some ramifications in the interfaces as well (replacing File with a URI).
I've implemented and tested that in default + blog, but will commit it another day (need to clean up & document some more). I think it is a step towards our goals re. creation API but surely not the end of the story.
(...) I'd rather have the following methods:
DocumentManager.add(document, documentType); DocumentManager.add(document, documentType, sourceDocument);
where the second one clones a source document.
I understand where this is coming from; but I am not sure this jives with the current mechanisms implementing the ParentChildCreatorInterface - we will need to pick that discussion up again later
(...) Then we should implement a site manager which does not restrict the site structure (mostly emtpy method bodies). What I'm still missing is a reasonable class name ... :)
Maybe it would make sense to consider the blog publication as something which uses a "flat" site tree ? (a Wiki publication could use that too)
I don't know if this can be handled by the existing TreeSiteManager. Or if there should be a "FlatSiteManager" in addition.
-- Wolfgang
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
