Andreas Hartmann wrote:
Why do we need both nodeName and documentId? Actually the document ID should be sufficient, that would even mean that the parent is unambigously defined.
+1
> @param documentTypeName the document type (aka resource type) of the > new document
Why don't we pass a DocumentType object? IMO OO code should use objects whenever possible and appropriate.
+1
> @param nodeType the node type, as defined by the constants in [EMAIL PROTECTED] > org.apache.lenya.cms.authoring.NodeCreatorInterface > NodeCreatorInterface}
Do we really need the NodeType concept? What is it used for? Is it even possible to obtain the node type of a document through the API?
no idea, please explain what nodeType is for?
> @param parameters any parameters the caller needs to pass to the creator
Can't we get rid of that? IMO it's a bad practise to allow polymorphism on the basis of arbitrary parameter sets.
precisely. that is the major brokenness of the current creator interface.
> @param useSiteManager set to true if the site manager is used in the
> publication; if set the site manager will be notified about the new
> document
IMO the site manager must be mandatory.
absolutely.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
