> > > > I think quite a large number of document instances are created in input > > modules (and maybe other sitemap components). > > Many input modules use the following code: > > > > Document document = getEnvelope(objectModel, name).getDocument(); > > > > which 'often' creates a new instance of the document, because the > > InputModules don't seem to be re-used. > > > > My question is: > > How is this related to repository sessions? > > Actually the identity map is attached to the repository session, which means > that already built documents should be taken from there. > > > Should the input modules (or other sitemap components) use the > > repository session attached to the request to access the document? > > At the moment they do (because the LenyaSourceFactory uses this session). > But in the future this probably has to be changed (see thread "Isolation of > active / inactive usecases").
Yeah, since your below-mentioned commit they really use the session (I'm talking about OperationModule.getDocumentIdentityMap() -> RepositoryUtil.getSession()). I was just a little bit too quick with my mail :-) > > BTW, I just committed some changes to the publication classes which seem > to have increased the performance (from about 7 to about 4 seconds per > authoring request on my machine). I hope this has removed some overhead. Wow, I just had a look at it and it has drastically improved! Thanks! BTW, I didn't start this thread because of performance concerns, but rather because I didn't understand the idea behind the identity map. I think I learned something... Josias > > -- Andreas > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
