Hi Lenya devs,

I had to disable the code which updates the search index in the
default publication instantiator.

Sorry for this rant, I'm just expressing some concerns and don't want
to offend anybody - the code is appreciated and just needs some
polishing. I'm sure the problems can be solved without too much effort.

----

The code works directly on patch files for cocoon.xconf. These files
aren't copied to the build directory anymore (well, they are
patch files ...).

The code violates SoC by handling component configuration, which
is the responsibility of the Avalon framework. It assumes the existence
of patch files and manipulates and applies the content of the patches
without using the framework. The "// TODO: release all objects" should
be taken care of. And it should be moved to the lucene module, the
instantiator shouldn't bother about search index configuration details.

----

IMO the code needs a redesign. Is someone familiar with it?
If not, I'll try to analyze it and look for solutions to the
problems mentioned above.

Again - apologies if someone feels offended.
Any support is greatly appreciated!

-- Andreas


--
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
[EMAIL PROTECTED]                     [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to