Andreas Hartmann wrote:


Hi Michi,

thanks for this!


[EMAIL PROTECTED] wrote:

Author: michi
Date: Sat Feb 25 16:39:52 2006
New Revision: 381035



--- lenya/trunk/src/java/org/apache/lenya/cms/publication/Publication.java (original) +++ lenya/trunk/src/java/org/apache/lenya/cms/publication/Publication.java Sat Feb 25 16:39:52 2006
@@ -171,6 +171,13 @@
     String getInstantiatorHint();
/**
+     * Returns the content dir.
+ * If the publication does not specify a content dir, then <code>null</code> is returned.
+     * @return A base directory where all the content is located.
+     */
+    String getContentDir();


Would you mind adding some more information to the javadocs?

- is it an absolute or relative path?
- if relative, where does it start from?


makes sense


Actually I think this method is not appropriate, because it assumes
file-based storage,


agreed

which is rather a responsibility of the SourceNodeFactory.

I'd propose to add the configuration option to the SourceNodeFactory:

<node-factories>

  <component-instance name="source" class="...">
    <content-directory src="..."/>
  </component-instance>

</node-factories>


the problem I see here is that it is publication specific ...

Michi




-- Andreas





--
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
[EMAIL PROTECTED]                        [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to