Michael Wechner wrote:
[...]
Do you think it's a "potentially harmful situation" if
the method
existsInAnyLanguage() returns false?
false, there is no language version and I think this should be indicated
by at least a WARNING
No, that's not the case. The check for the existing language version
implicates that the caller is aware of the case that the language
version does not exist. This method could be called, for instance, to
enable / disable the "Create language version" menu item.
IMHO, only the caller of this method can determine whether the result
(true or false) is harmful for the application. For the method itself,
either result is fine.
I totally agree to Josias.
the problem I see is that the DefaultDocument is an implementation and
if the implementation
itself does not throw a WARNING or an ERROR, but only higher up, then
it's very hard to debug
where the actually problem is located.
I don't understand this implication. You throw an exception when a
problem occurs. Why should you log a warning if the caller might
interpret the result of this method as a problem? Then you could
log warnings in virtually every line of the code.
If one would throw a stacktrace
then it should be alright,
but so far we don't log stacktraces for WARNINGS.
If an exception is thrown, a stack trace is logged.
-- Andreas
--
Andreas Hartmann
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
[EMAIL PROTECTED] [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
