Andreas Hartmann wrote:
and commit-then-review for trunk.
Just for my understanding - would that mean to apply patches by
non-committers and commit them without reviewing? If yes, I don't
agree to this policy. At least a code review should be done.
The recent Summer of Code contribution required (or will require)
some serious post-treatment
(see http://issues.apache.org/bugzilla/show_bug.cgi?id=38572).
IMO the contributor should be notified if the patch doesn't
comply our principles / guidelines, and should get the chance
to rework the code before it's committed.
agreed. CTR applies to committers only. the idea behind CTR is to have
more fluid development by putting more trust on the committers. outside
contributors haven't earned this trust yet and can't get their code
committed without review. often, that review happens on bugzilla.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
