El mar, 30-05-2006 a las 23:01 +0200, Andreas Hartmann escribió:
> Thorsten Scherler wrote:
>
> [...]
>
> >> Can you remember why the condition was introduced?
> >> Maybe it was a workaround for the source extension problem?
> >
> > Yes, it was an extension and external content dir workaround. The
> > problem was when writing the code that I needed to know where to create
> > the odt document.
>
> I took a closer look at the code and didn't find any differences
> to the base classes apart from the source extension. So I stripped
> the class down to this, resulting in
>
> public class CreateOpenDocument extends CreateDocument {
>
> protected static final String ODT_EXTENSION = "odt";
>
> protected String getSourceExtension() {
> return ODT_EXTENSION;
> }
> }
>
>
> I can create ODT documents this way. Would you mind giving it a try?
>
> Thanks!
I tested it on the default pub and another pub that was using an
external content dir. It works for both so I committed the changes.
http://svn.apache.org/viewvc?rev=410503&view=rev
Thanks for the headsup and the slim fast solution.
>
> BTW, we should consider handling the source extension in another
> way (configuration?). It's not very convenient to add a class just
> for a different source extension.
Yeah, you are totally right. Maybe it is time to talk again about the
register extension with resource type on a global basis.
http://marc.theaimsgroup.com/?t=114258900800004&r=1&w=2
wdyt?
salu2
> And IMO the resource type shouldn't be passed from the menu item as a
> request parameter, but rather be configured in cocoon.xconf.
>
> -- Andreas
>
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
[EMAIL PROTECTED] [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
