El lun, 05-06-2006 a las 11:59 +0200, Jörn Nettingsmeier escribió: > On a sad and lonely bank holiday, Thorsten Scherler made my day by writing: > > El sáb, 03-06-2006 a las 19:43 +0200, Jörn Nettingsmeier escribió: > >> hi thorsten, hi everyone! > >> > >> > >> i'm extending the LenyaMetaDataGenerator to provide clean xml output > >> that can be easily handled in xsl stylesheets. > >> i started by copying and modifying it, and now i want to make it a clean > >> subclass, because i only need to change one method (private void > >> parseMetaData(String type)). > >> > >> the problem is that many methods are declared private... are there > >> objections against lifting the restrictions to "protected"? > >> > > > > yes. > > can you be more specific?
Sorry. Yes we can lift the private restrictions where possible. > what am i supposed to do instead? modify the original generator? or wrap > it? if so, why? (note the "java *newbie*" in the subject :-D) No, sorry just replace private with protected like you did in your patch. > > >> and, since i would like to submit it for inclusion once it's been > >> cleaned up, what are the preferred coding standards wrt. whitespace and > >> code formatting in lenya? > >> > > > > http://lenya.apache.org/1_2_x/misc/coding-guidelines.html > > thanks. ummm, i think i used tabs quite a bit... i'll rework the patch > later today. :) Thanks (and please attach it to the issue tracker). salu2 > best, > > jörn > > -- Thorsten Scherler COO Spain Wyona Inc. - Open Source Content Management - Apache Lenya http://www.wyona.com http://lenya.apache.org [EMAIL PROTECTED] [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
