Thorsten Scherler wrote:
[...]
filteringProperties = loadXMLPropertiesFromURI(filteringProperties,
lenyaPropertiesStringURI);
- } catch (FileNotFoundException e) {
- if (debugging())
- debug("Unable to find local.lenya.properties.xml, ignoring.");
- }
Is this intended?
Yes.
IIUC the Exception is just swallowed in non-debug mode.
That looks like exception handling for flow control, which is a Bad Thing.
Shouldn't we check if the file exists instead?
See loadXMLPropertiesFromURI(...) there is a source.exist() that is why
FileNotFoundException will not appear anymore. Since they do not appear
it does not make sense to catch them (that is why I removed them).
I guess it was too early in the morning, I didn't pay attention to the - signs.
Sorry ...
Why do you think we should keep it?
Why was it there before?
http://svn.apache.org/viewvc?rev=428447&view=rev
I agree with your opinion that is why I opened
https://issues.apache.org/jira/browse/FOR-914 a week ago.
That's very good to know :)
-- Andreas
--
Andreas Hartmann
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
[EMAIL PROTECTED] [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
