On Thu, 2006-09-21 at 15:16 +0200, Jörn Nettingsmeier wrote: > Josias Thöny wrote: > > On Thu, 2006-09-21 at 12:30 +0200, Jörn Nettingsmeier wrote: > >> this little patch corrects invalid css statements. > >> can you please look at it and tell me if this bogus "display" value and > >> the comment are there for a reason? (it looks like it might be one of > >> those quirky browser-specific hacks, but since it's obviously invalid, > >> i'd a last like to see it commented if it has to stay.) > >> > >> if nobody objects, i'll submit it to svn. > > > > Do you mean the "inline-block" display value? AFAIK it is understood by > > IE, see e.g. > > http://www.quirksmode.org/css/display.html#inlineblock > > > > The comment is probably a IE hack also, see > > http://de.selfhtml.org/css/layouts/browserweichen.htm#kommentar_hack > > (sorry, german link) > > > > But if your fix is tested with IE and Firefox, I'd be happy to see those > > hacks removed. > > > YUCK. you are right, some IE versions do indeed fall apart when correct > css is used. > i will revert the patch for now, but at some point the default > publication layout needs to be redone using only standards-compliant css > without quirks for single vendors. (and no, the fact that the world's > most crappy browser implementation has a market share of 90something > percent is no excuse.) the lenya menu looks like it could be simplified > a lot... some day.
Agreed, the menu should be rewritten to use standard-compliant CSS. BTW, welcome to your first commits! No commit mail appeared on the commit list so far, does anybody know what's wrong? Do we somehow have to add Jörn to the allowed senders? thanks, Josias > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
