DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42161>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42161 ------- Additional Comments From [EMAIL PROTECTED] 2007-04-25 06:36 ------- Thanks for the patch! But there's a little problem (which is the reason why I didn't make this change yet): +++ src/modules-core/workflow/java/src/org/apache/lenya/workflow/impl/WorkflowEngineImpl.java (working copy) @@ -20,6 +20,7 @@ import java.util.ArrayList; import java.util.List; +import org.apache.lenya.cms.workflow.LenyaVersion; The code in org.apache.lenya.workflow is meant to be generic for SoC reasons, i.e. it shouldn't know anything about the CMS. That's why it shouldn't import anything from o.a.l.cms.workflow. IMO a clean solution would be to use an abstract factory to generate version objects. The o.a.l.workflow package uses versionFactory.createVersion(...) The o.a.l.cms.workflow package provides an implementation which generates LenyaVersion objects. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
