On Mon, 2007-05-14 at 13:07 +0200, Thorsten Scherler wrote: > On Mon, 2007-05-14 at 11:38 +0200, Andreas Hartmann wrote: > ... > > > Meaning another option is to limit the revision to the main document, > > > which is as well producing the overview in > > > http://localhost:8888/default/authoring/index.html?lenya.usecase=tab.revisions > > > > > > The revision link would open only the document (no nav, no menu, no > > > nothing else but the result of > > > {resource-type:format-xhtml}?rendertype={1}. > > > > > > wdyt? > > > > That would certainly be an option, but it would require hard-coding > > the revision handling in sitemaps. We'd have to introduce a generic > > concept of "page" vs. "revision" rendering. > > Requesting > http://localhost:8888/default/authoring/index.html?lenya.revision=2 > is triggering which code? > > I just was looking were lenya.revision=2 get resolved. Can you point me > to the code? > > I thought that I could find something like: > > RCML rcml = getSourceDocument().getRepositoryNode().getRcml(); > int version= getParameter("lenya.revision"); > Document doc = rcml.getBackupEntry(version); > > We would need to write rcml.getBackupEntry(int version){} and above goes > in a generator that returns the sax out of the doc. > > That would not make it necessary to hard code the revision handling. > > Having a match like > <map:match type="request-parameter" pattern="lenya.revision"> > <map:generate type="revision"/> > <map:serialize type="xml"/> > </map:match>
With this as base on could as well implement easy a diff output like we have in svn revision (e.g. colored diff between two version). AKA Document doc = rcml.getBackupEntryDiff(version,otherVersion); Where we could make the generator configurable like <map:generate type="revision"> <map:parameter name="diff" value="true|false"/> </map:generate> salu2 -- Thorsten Scherler thorsten.at.apache.org Open Source Java consulting, training and solutions --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
