DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=43047>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43047 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX ------- Additional Comments From [EMAIL PROTECTED] 2007-08-08 03:34 ------- (In reply to comment #1) > (In reply to comment #0) > > we have a mechanism in place that allows modules to create their own > > patches in > > the root sitemap.xmap, by placing patchfiles in config/sitemap. > > these are currently named FOO.xmap. we have agreed before that all > > patchfiles > > should end in .xconf. > > Have we? IIRC this applies only to patch files for cocoon.xconf. > In Cocoon, patch files for sitemaps also end with .xmap. ok. i wasn't aware of that... > > moreover, it seems odd that we have a subdirectory cocoon-xconf, but sitemap > > patches are not in it. > > They aren't in there because they don't patch cocoon.xconf ... > > > i propose the following: > > move $MODULE/config/sitemap to $MODULE/config/cocoon-xconf/sitemap > > move $MODULE/config/cocoon-xconf/sitemap/*xmap to {...}.xconf > > -1 > > IMO it should be left as it is now. agreed. still, it's a little weird that files that are xpatches should have the same ending as the files they're supposed to patch, since they require different treatment. but if cocoon does it, that's more than reason enough to do it the same way. thanks for your comments. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
