Andreas Hartmann wrote:
Jörn Nettingsmeier schrieb:

Andreas Hartmann wrote:

* SourceNodeRCMLs are now singletons per source URI, i.e. for
each source URI only one RCML object is created. This allows to
synchronize access to the RCML methods, avoiding concurrent
modifications.
let me see if i'm getting this: a source URI is a uuid? or a uuid
plus language? or uuid plus language plus revision? no, the last
wouldn't make sense... can you elaborate?

ATM source URIs are lenya:// URIs. E.g., the sitetree has a source URI which doesn't contain a UUID.

ah, so the revision controller still uses the old repository access
based on the sitetree path... so iiuc, in terms of the new repository
api, we have one SouceNodeRCML per uuid per language. which implies that
 users can work on different translations of the same document
concurrently. nice.

what happens to other sessions that want to commit? do they spin,
or are they being notified, or does the user see an error and is
prompted to retry?

They are just blocked by the JVM.

ah, nice. in unix terms, that would mean they are not spinning (polling regularly), but go to sleep and are only re-activated when the resource is available again... so it's easy on server resources.

Committing a session should usually
 be a matter of some milliseconds, so the user shouln't notice. It
can happen in high load conditions, though.

well, as long as the user is not forced to do something special to fix it, it's fine. waiting a second is ok imho (for now - eventually we'll have to tune lenya for speed, but certainly not now :)

I know this isn't the
most elegant approach, but in this area we should go for the safest
solution. Synchronization issues in the commit stage can lead to an
inconsistent repository (which occured during my load tests).

i like it. it's safe, non-intrusive and easy to verify, which is good.
from your first comment, i wasn't sure if you just were just making it fail like the indexing, and the user would have to take some action...

thanks for your comments,

jörn


--
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to