DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=43112>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43112 ------- Additional Comments From [EMAIL PROTECTED] 2007-08-13 13:05 ------- (In reply to comment #0) i'm not familiar with this code, but anyways... >src/modules/sitetree/java/src/org/apache/lenya/cms/cocoon/transformation/DocumentIndexTransformer.java > In setup(), envelope is set to null, never changed, and then referenced. This > should throw a NPE every time. looks like dead code to me. grep -ri "transform.*index" coughs up just one match - the original component declaration in the global sitemap. unless i'm overlooking something, this is unused. can anyone confirm this? if so, let's chuck it out. >src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java > In add() node is set to a value under the 2nd if, but never used. The if under > the following else perhaps needs to be moved out from the else. no idea. but the node assignment is probably there for its side effects in "tree". src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java > In copy() destNode is set, checked, and reset, but never used. yuck. "tree", "tree2" - some people really hate programming, it seems. again, the assignment seems to be there for its side effects. this module makes me wonder why a simple site tree needs to be rocket science... i guess i'll leave the maintenance to the rocket scientists :( -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
