Andreas Hartmann wrote:
> Markus Angst schrieb:
>> Hi Andreas,
>>
>>>> Jürgen just pointed me to your commits re Mark AxisUUIDGenerator as 
>>>> ThreadSafe
>>>> (revisions 570864 and 570866). I guess you also have experienced a 
>>>> "document
>>>> already exists" message. Mine was during import of the example content.
>>> you mean the problem occured after my check-in? 
>> Sorry, my post was unclear. I experienced the problem before your commit. 
>> Your
>> commit fixes the problem as far as I can tell. Thanks for the fix :-)
> 
> I didn't experience the problem before, I just noticed during memory
> leak debugging that each modifiable session created its own
> AxisUUIDGenerator instance, which woulnd't be necessary :)

The problem I experienced during example content import was an attempt to create
two subsequent documents with the same UUID. It looked like a timing problem;
when i started lenya with the option "servlet-debug" the problem did not occur
any more.

>>> I couldn't reproduce it (yet), but you might try to synchronize the 
>>> nextUUID() 
>>> method in the AxisUUIDGenerator.
>> That's where my point comes. I think the axis people have found the bug in 
>> their
>>  FastUUIDGen.java and fixed it on 2006-09-22. See
>> http://svn.apache.org/viewvc/webservices/axis/trunk/java/src/org/apache/axis/components/uuid/FastUUIDGen.java?r1=264831&r2=448984
>> for the diff.
>> The problem is that cocoon comes with axis jars that were released on
>> 2004-12-16. I think that cocoon should update their jars. Don't know how 
>> simple
>> that is, though.
> 
> You could send a mail to cocoon-dev, I don't think they'll object to
> updating.

I will do that.

>> I don't understand enough of the ThreadSafe interface
> 
> It just tells the container to create only one instance of the service
> which is shared by all clients.

Does this guarantee that a synchronization bug which is definitely present in
the old version of FastUUIDGen.nextUUID() cannot occur? You can see that this is
what they fixed when you have a quick peek at the diff i mentioned.

>> but i think your commit is
>> only masking the real bug which is located in the old axis jars of cocoon.
> 
> OK, than we should definitely tell them to update the jars.
> Thanks for the explanation!

I am not feeling to explain anything to you because i would simply not be able
to. It would rather have to be the other way round ;-) I only want to help make
things better by expressing my humble opinion and pointing to stuff that i found
which i feel would be worth having a look at :-)

Thanks!
Markus

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to