2011/10/20 Tomaž Muraus <[email protected]>: > I just checked your pull request and in general I like what I saw and I > think it's a step in the right direction. > > Our goal should be to make the base classes as smart as possible so we can > reduce amount of the repeated and Response munging code in the driver files. >
Great, got it. I've updated the branch and created a proper pull request on github: https://github.com/apache/libcloud/pull/32 So now code review can flow through github -- or do you prefer another method? > On Wed, Oct 19, 2011 at 2:33 PM, Caio Romão <[email protected]> wrote: <snip> >> Conjecturing: >> >> Is adding logic to the Response class the best way to do this kind of >> verification? > > > I think having error handling logic in Response class is OK. Adding another > class or something like that wouldn't really reduce the complexity or make > error handling code more simple or clear. > > I'm definitely open to better ideas though. > No better idea currently, I'll sleep on it and if I come up with anything feasible I'll bring the topic back up again. Cheers
