Just checked the patch, here are some of the issues I have noticed:
1.
int(element.findtext('MEMORY', None)
This will thrown if MEMORY key is not present.
This also means all the "self.assertTrue(node.size.cpu is None or
isinstance(size.cpu, int))" asserts are wrong - currently there is no way
for node.size.cpu / node.size.ram to be None.
2.
except InvalidCredsError as detail
This won't work with older Python versions. Now that we also support Python
3 we need to do something like this:
except InvalidCredsError:
detail = sys.exc_info()[1]
Otherwise it looks good to me.
On Tue, Dec 6, 2011 at 12:01 AM, Hutson Betts <[email protected]> wrote:
> An update patch for the OpenNebula compute node for consideration.
>
> Changes:
> * Removed unused JSON import.
> * Added two new node drivers for OpenNebula, for OpenNebula v3.0 and
> v3.2, which support additional functionality over the OpenNebula v2.0
> driver.
> * Added test suites for those additional capabilities.
> * Removed destroy() from OpenNebulaNetwork which is not supported by
> the compute node driver.
> * Removed unused assignments, mostly pertaining to ET.SubElement.
> * Added ability to define the name under which the node image will
> be
> saved after shutting down for v3.0+.
> * Added support for a network attribute for v3.0+.
> * Added support for the upcoming OpenNebula v3.2, and it's new
> instance
> type interface.
> * Added additional tests for a more complete test coverage.
>
> --
> Hutson Betts
> Computer Science and Engineering
> Texas A&M University
>
>
>
