[
https://issues.apache.org/jira/browse/LIBCLOUD-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181792#comment-13181792
]
Tomaz Muraus commented on LIBCLOUD-140:
---------------------------------------
Hey, I just checked the patch and here are a few comments:
- to_dict should be a "private" method for now (prefixed with an underscore)
- RackspaceAccessRule id attribute seems to be an int. In other places ids are
string so for consistency we should also stick to strings here
- missing docstrings for new methocs
Otherwise it looks pretty good!
> Rackspace LB Driver: Update Configuration Options/Update Members/Bulk Deletes
> -----------------------------------------------------------------------------
>
> Key: LIBCLOUD-140
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-140
> Project: Libcloud
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Dave King
> Priority: Minor
> Labels: loadbalancer, rackspace
> Attachments: libcloud-140-attempt-1.patch,
> libcloud-140-attempt-2.patch, libcloud-140-attempt-3.patch
>
>
> Currently the Rackspace Cloud Load Balancer API exposes Health Monitors,
> Connection Throttle, Connection Logging, Session Persistence, Error Pages,
> and Access Lists.
> Libcloud should expose these to be updated/disabled (like name, protocol, and
> port are currently allowed).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
