[
https://issues.apache.org/jira/browse/LIBCLOUD-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488097#comment-13488097
]
Tomaz Muraus commented on LIBCLOUD-251:
---------------------------------------
Thanks for the patch. I've merged it into trunk with the following changes:
- Use urlencode from libcloud.utils.py3
- Use self.assert* methods instead of assert (changed MockHttp class to inherit
from unittest.TestCase)
- if self.network -> if self.network is not None
- body -> str(body) inside the test, inside Python 3.2 body type is bytes, not
str
- other style things - line length, " -> ', etc.
- Use new style classes (inherit from object)
There are still a bunch of issues which can be solved in a nicer way. For
examples:
+ # This is a workaround for filter parameter encoding
+ # the urllib encodes (name==Developers%20Only) into
+ # %28name%3D%3DDevelopers%20Only%29) which is not accepted by vCloud
But I decided to merge an initial version and you can incrementally fix other
things. You can see all the changes I made at
http://svn.apache.org/viewvc?view=revision&revision=1404292
Next time please make sure issues like this are addresses when attaching a
patch. Thanks!
> Expose query and control settings functionality for vCloud driver
> -----------------------------------------------------------------
>
> Key: LIBCLOUD-251
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-251
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Affects Versions: 0.11.2
> Reporter: Michal Galet
> Labels: vcloud
> Attachments: LIBCLOUD-251.patch
>
>
> * Provide functionality to get and set control access for vApps. This way
> created vApps can be shared between users/groups or everyone.
> * Expose generic query method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
