[
https://issues.apache.org/jira/browse/LIBCLOUD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530653#comment-13530653
]
Tomaz Muraus commented on LIBCLOUD-249:
---------------------------------------
Thanks, I have reviewed the updated patch. It mostly looked good, but there
were still some issues which I have fixed myself:
1. responseCls attribute belongs to the Connection class and NOT driver class.
2. DNS_PARAMS_HOSTVIRTUAL = ('key') - missing a comma, comma makes a tuple.
3. You have used the same response class (HostVirtualResponse) in the compute
and DNS driver and referenced DNS API specific exceptions inside the compute
driver. This is a bad practice in many way (code reuse, APIs shouldn't be
tighly coupled, etc.).
I have moved common functionality into a separate module
(libcloud.common.hostvirtual.{HostVirtualConnection,HostVirtualException,HostVirtualResponse})
and created a HostVirtualDNSResponse sub-class inside
libcloud.dns.drivers.hostvirtual which throws DNS related exceptions.
I have also merged patch into trunk now. Please have a look at the diff and the
changes I made - http://svn.apache.org/viewvc?view=revision&revision=r1421073
Thanks!
> This patch adds support for HostVirtual API http://www.vr.org/ (compute and
> dns driver)
> ---------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-249
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-249
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute, Core, DNS
> Reporter: Dinesh Bhoopathy
> Assignee: Tomaz Muraus
> Labels: compute, dns, patch
> Attachments: hostvirtual.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
