[ 
https://issues.apache.org/jira/browse/LIBCLOUD-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598330#comment-13598330
 ] 

Tomaz Muraus commented on LIBCLOUD-278:
---------------------------------------

[~jdevesa] no problem.

We should have done a better job with the review and have tests to catch issues 
like this in the first place :)

In any case, if you go over past couple of comments in this ticket you can see 
I've pushed some commits which revert the original change and fix it in the 
correct place (ScriptDeployment.run method).

I would appreciate if you could go over those commits and verify that they look 
reasonable and fix the original issue you had.
                
> Name a ScriptDeployment object without absolute path fails the execution
> ------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-278
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-278
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.11.2
>            Reporter: Jaume Devesa
>            Assignee: Tomaz Muraus
>             Fix For: 0.12.1
>
>         Attachments: libcloud_278_full.patch, libcloud_278.patch
>
>
> If you set a name to a ScriptDeployment this way:
> sd = ScriptDeployment('touch total_success', name='success.sh')
> it fails the execution when you call the conn.deploy_node() function without 
> feedback to the user. 
> The 'put' method of the 'ParamikoSSHClient' copies the file 'success.sh'  in 
> the relative path of the logged user (/root/success.sh or 
> /home/ubuntu/success.sh in Ubuntu machines), but the 'run' method of the same 
> class runs directly the 'success.sh' script and this file is not in the 
> classpath. 
> If you set the line previous to the return statement of the 'run' method:
> print ("Out: '%s', Error: '%s', Status: '%d'") % (so, se, status)
> You get:
> Out: '', Error: 'bash: success.sh: command not found', Status: '127'
> If the name of the 'ScriptDeployment' is an absolute path (sd = 
> ScriptDeployment('touch total_success', name='/home/ubuntu/success.sh')), the 
> execution runs fine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to