[ 
https://issues.apache.org/jira/browse/LIBCLOUD-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665695#comment-13665695
 ] 

Tomaz Muraus commented on LIBCLOUD-330:
---------------------------------------

I don't like this kwargs method too much. It's not explicitly and user doesn't 
know what is going on and which arguments are actually being used.

I would prefer to do one of the following:

1. Add extra_args argument (dictionary) to the method and document which are 
the valid keys for this dictionary
1. Explicitly define additional arguments which this method can take (e.g. 
eg_foo1=None, ex_foo1=None, ..) and build extra_args dictionary inside the 
method
                
> CloudStack driver does not take extra args in the deployVirtualMachine call
> ---------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-330
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-330
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>         Environment: latest libcloud trunk
>            Reporter: sebastien goasguen
>
> the extra args in the create_node() is an empty dictionary, therefore things 
> like keypairs cannot be passed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to