[
https://issues.apache.org/jira/browse/LIBCLOUD-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665781#comment-13665781
]
Tomaz Muraus commented on LIBCLOUD-329:
---------------------------------------
I've refactored your patch a bit and merged it into trunk:
- I've removed "if 'ipaddress' in nic.keys():" change because what we currently
do ("if 'ipaddress' in nic") is more "pythonic" and does the same thing
- On create_node I only populate "private_ips" because the returned IPs are
private one. In your patch you populated both public_ips and private_ips with
the same value which is not OK.
- I've also added some tests. It's actually scary how under tested this driver
is.
Thanks
> CloudStack driver does not return ip addresses properly
> -------------------------------------------------------
>
> Key: LIBCLOUD-329
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-329
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Environment: OSX, latest trunk from git
> Reporter: sebastien goasguen
> Attachments: cloudstack.patch
>
>
> the private ips and publics ips are not returned properly. If a cloud does
> not use floating ips but instead assigns public ips directly to the instance,
> the public ip is set as a private ips.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
