[
https://issues.apache.org/jira/browse/LIBCLOUD-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678675#comment-13678675
]
Tomaz Muraus commented on LIBCLOUD-336:
---------------------------------------
[~gestator] Thanks. There are still a bunch of style issues with your patch
(pep8, camelCase instead of underscore separeated names, ...). Please follow
the guidelines at http://libcloud.apache.org/contributing.html.
A couple of other things:
1. Use ValueError instead of SizeFit
2. Use % instead of .format. .format is not available in Python 2.5 which we
still support.
3. Function is missing a docstring and tests
> Add multi port and protocol in create loadbalancer and create healthcheck.
> this is in ELB
> ---------------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-336
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-336
> Project: Libcloud
> Issue Type: New Feature
> Components: LoadBalancer
> Affects Versions: 0.12.3
> Environment: AWS
> Reporter: Frederic Michaud
> Labels: patch
> Attachments: elb correct code review - add healtcheck -add balancer
> listener.patch
>
>
> fix code for accepte many port and protocol. create heltcheck methode for the
> ELB
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
