[ 
https://issues.apache.org/jira/browse/LIBCLOUD-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691773#comment-13691773
 ] 

Tomaz Muraus commented on LIBCLOUD-349:
---------------------------------------

I just tried applied patch onto trunk and it doesn't seem to apply cleanly:

{quote}
Applying: Added unittest for the list_images method in the Cloudstack driver
error: patch failed: libcloud/compute/drivers/cloudstack.py:157
error: libcloud/compute/drivers/cloudstack.py: patch does not apply
error: patch failed: libcloud/test/compute/test_cloudstack.py:20
error: libcloud/test/compute/test_cloudstack.py: patch does not apply
Patch failed at 0001 Added unittest for the list_images method in the 
Cloudstack driver
The copy of the patch that failed is found in:
   /w/lc/libcloud/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
{quote}

Can you please make sure the patches are generated against the latest trunk 
version of the code base?
                
> no tests for list_networks and list_templates in cloudstack driver
> ------------------------------------------------------------------
>
>                 Key: LIBCLOUD-349
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-349
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.12.3
>            Reporter: sebastien goasguen
>             Fix For: 0.12.3
>
>         Attachments: list_images.patch, list_networks.patch
>
>
> no tests in test_cloudstack.py for list_networks and list_templates, even 
> though the fixtures are there

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to