Replies are in-line.
On Thu, Dec 5, 2013 at 11:22 PM, John Carr <[email protected]> wrote:
> Hey,
>
> >
> >>
> >> I had been considering adding another NodeAuth type object for these
> >> public keys, so you could pass a NodeAuthKeyName to the auth kwarg. EC2
> et
> >> al would then:
> >>
> >> class NodeDriver:
> >>
> >> features = {'create_node': ['ssh_key_name']}
> >>
> >
> > This seems reasonable to me.
> >
> > If user specifies NodeAuthKeyName for auth argument, you would then pass
> > "keypair_name" (or whatever we end up calling this argument) to the
> > create_node method, right?
>
> I was thinking:
>
> driver.create_node(…, auth=NodeAuthKeyPair(“keypair_name”))
>
> I push for that because the auth argument is used to set an initial
> password or initial ssh key. Choosing a key pair is basically the same
> thing, it seems weird to have a separate argument.
>
OK, yeah, that sounds good. Thanks for the clarification.
> Perhaps your KeyPair class is a NodeAuth class..
>
In this case we would need to make all the arguments expect "name" optional
which I'm not a big fan of.
>
>
> Cheers,
> John
>
>
