Hey, Thanks for the proposal. Proposed changes look good to me.
The changes are also "additive" in nature and more or less backward compatible so there should also be no issues with introduction them. On Thu, Mar 12, 2015 at 12:06 PM, Allard Hoeve <[email protected]> wrote: > Hey all, > > I am using libcloud as an abstraction layer between OpenStack and EC2. I am > currently working to remove any inconsistencies in the API between them. > [479] <https://github.com/apache/libcloud/pull/479> [473] > <https://github.com/apache/libcloud/pull/473> [467] > <https://github.com/apache/libcloud/pull/467> [462] > <https://github.com/apache/libcloud/pull/462> [451] > <https://github.com/apache/libcloud/pull/451> [450] > <https://github.com/apache/libcloud/pull/450> > > I've prepared a patch that adds a state attribute to StorageVolume objects > like it is an attribute of Nodes. This state is derived from the state, > status or whatever attribute that is now in extra and differs between > drivers. This PR maintains those fields in extra, so the patch is > backwards-compatible. > > I am asking for your comments on this PR: > https://github.com/apache/libcloud/pull/476 > > > 1. I've added support for EC2 and OpenStack, but I have no experience > with other cloud providers, so there are no implementations in other > drivers. > 2. The status attribute defaults to storage when: > 1. The driver does not implement mapping. > 2. The driver encounters an unknown status. > > So in effect, OS and EC2 return the unified statuses, but other drivers > report UNKNOWN statuses. This will improve as people implement the mapping > in drivers as we go along. > > No doubt other drivers have status codes that could be mapped, please let > me know. > > Best, > > Allard >
