I understand the motivation here, but I think we need to be careful. Expecting people to reopen valid PRs isn't really a good approach, IMO. Those people will just move along and use something else, or worse, fork the project. I keep encouraging my coworkers to contribute fixes upstream, but they keep working around them in our code because there is a sense that their contributions to libcloud will be ignored. As I say that, I realize I haven't contributed much myself, so I should remedy that as well.
It's not clear to me if -1 is 'close' or 'keep'. If it's close, please do not close the retry on SSLError fix. That's a valid production use-case that affects us, and the developer in question already has a really sour opinion of this project due to it languishing for months without review. My $0.02 Greg On 11/23/15, 9:20 AM, "Allard Hoeve" <[email protected]> wrote: >Sure, clean it up, people can reopen the PRs easily. > >:+0.9: > >On Mon, Nov 23, 2015, 16:13 Eric Johnson <[email protected]> >wrote: > >> Formatting of the email was a bit hard to parse and I'm not sure how >>well >> an in-line reply will look. >> >> So, rather than one-off a few here or there, put me down for 100% >>agreement >> with Tony's votes. >> >> On Mon, Nov 23, 2015 at 1:36 AM, anthony shaw <[email protected]> >> wrote: >> >> > Shouldn't be too contraversial, here is the list, with a vote column. >> > Kami Seb Jerry Pquerna Ant Eric >> > Add "ttl" attribute to the libcloud.dns.base.Record class >> > #639 opened 10 hours ago by Kami >> > -1 >> > [WIP] CloudFlare DNS driver >> > #637 opened a day ago by Kami 1 of 3 >> > -1 >> > GoogleStorageDriver can now use either our S3 authentication or otherŠ >> > #633 opened 9 days ago by crunk1 >> > -1 >> > [WIP] LIBCLOUD-769 backup driver >> > #629 opened 14 days ago by tonybaloney >> > -1 >> > [LIBCLOUD-768] UnicodeDecodeError occurs when LIBCLOUD_DEBUG is set >> > #628 opened 16 days ago by atsaki >> > -1 >> > Turn all States into string values instead of ints >> > #624 opened 20 days ago by allardhoeve >> > -1 >> > [LIBCLOUD-763] Simplify str2dicts util function >> > #613 opened 29 days ago by annp89 >> > -1 >> > [LIBCLOUD-604] Add 'ex_list_subnets' to OpenStack provider >> > #600 opened on Oct 13 by hannanabdul55 >> > -1 >> > Modify CloudStack Connection class so it looks more like other connecŠ >> > #598 opened on Oct 11 by toodaaloo >> > -1 >> > Added Runabove storage >> > #586 opened on Sep 24 by ZuluPro >> > -1 >> > Libcloud 742 verizon compute >> > #572 opened on Sep 3 by replicant0wnz -1 >> > [LIBCLOUD-728] Add SSLError to retry decorator exceptions >> > #556 opened on Jul 31 by thesquelched >> > -1 >> > [WIP] Support for pickling Driver instances and other Libcloud objects >> > #549 opened on Jul 19 by Kami >> > -1 >> > [LIBCLOUD-721] work around http proxy for raw requests >> > #547 opened on Jul 14 by nferch >> > -1 >> > [LIBCLOUD-720] GCE job timeout modification. >> > #543 opened on Jul 8 by gabik >> > -1 >> > get_container can parse a 200 status code >> > #531 opened on May 29 by wpjunior >> > 1 >> > [LIBCLOUD-711] Fixed occasional CRC check failure when decompressing Š >> > #519 opened on May 14 by chrisob >> > 1 >> > Reset file's current position in read_in_chunks() >> > #509 opened on Apr 23 by kun--hust >> > 1 1 >> > Add a 'break' in iterate_container_objects() >> > #508 opened on Apr 23 by kun--hust >> > 1 >> > Update vultr.py >> > #497 opened on Apr 3 by cr0hn >> > 1 >> > Support diskSizeGb and local SSD when creating an instance on GCE >> > #496 opened on Apr 2 by phildav >> > 1 >> > [LIBCLOUD-655] OpenStack identity component does not refresh auth >> tokens... >> > #452 opened on Feb 13 by Jacob-E >> > 1 >> > Fixes LIBCLOUD-651, Route53 cant delete a multiple value record >> > #432 opened on Jan 10 by Itxaka >> > 1 >> > [W.I.P.] [RFC] New base libcloud.networking API >> > #345 opened on Aug 5, 2014 by Kami -1 >> > allow specifying standard as a domain in >>ex_associate_address_with_node >> > #335 opened on Jul 3, 2014 by zerthimon >> > 1 >> > [LIBCLOUD-592] Create a generic method for listing AWS EIPs >> > <https://github.com/apache/libcloud/pull/334> >> > #334 opened on Jul 3 2014 by zerthimon >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aze >>rthimon >> > > >> > 1 LIBCLOUD-590 - Reduce redundant API calls of CloudStack compute >> > driver's... <https://github.com/apache/libcloud/pull/332> #332 opened >> on >> > Jul 1 2014 by atsaki >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aat >>saki >> > > >> > 1 [LIBCLOUD-588] Add ex_node_ids and ex_filters to list_volumes() >> > <https://github.com/apache/libcloud/pull/329> #329 opened on Jun 27 >>2014 >> > by >> > zerthimon >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aze >>rthimon >> > > >> > 1 [LIBCLOUD-587] ex_modify_network_attributes method >> > <https://github.com/apache/libcloud/pull/328> #328 opened on Jun 27 >>2014 >> > by >> > zerthimon >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aze >>rthimon >> > > >> > 1 [LIBCLOUD-586] allow EC2SecurityGroup objects be specified when >> > creating... <https://github.com/apache/libcloud/pull/326> #326 opened >> on >> > Jun 27 2014 by zerthimon >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aze >>rthimon >> > > >> > 1 [LIBCLOUD-540] [WIP] Copy object >> > <https://github.com/apache/libcloud/pull/314> #314 opened on Jun 11 >>2014 >> > by >> > rgbkrk >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Arg >>bkrk >> > > >> > 1 [LIBCLOUD-557] Updated list_nodes to categorize private_ips and >> > public_i... <https://github.com/apache/libcloud/pull/296> #296 opened >> on >> > May 20 2014 by sasi5a1 >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Asa >>si5a1 >> > > >> > 1 [LIBCLOUD-518] Automatically detect domain of Elastic IPs. >> > <https://github.com/apache/libcloud/pull/275> #275 opened on Apr 9 >>2014 >> by >> > tomprince >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Ato >>mprince >> > > >> > 1 restore the connection request_path in case of failed request. >> > <https://github.com/apache/libcloud/pull/274> #274 opened on Apr 9 >>2014 >> by >> > mgogoulos >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Amg >>ogoulos >> > > >> > 1 Unpack the iterator before getting its length. >> > <https://github.com/apache/libcloud/pull/250> #250 opened on Feb 11 >>2014 >> > by >> > coderanger >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Aco >>deranger >> > > >> > 1 Cache cdn container url for performance improvements >> > <https://github.com/apache/libcloud/pull/233> #233 opened on Jan 31 >>2014 >> > by >> > jobelenus >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Ajo >>belenus >> > > >> > 1 Issue LIBCLOUD-500 : support extra arguments to >> > CloudStackNodeDriver.list_nodes() >> > <https://github.com/apache/libcloud/pull/227> #227 opened on Jan 21 >>2014 >> > by >> > gza >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Agz >>a >> > > >> > 1 Issue LIBCLOUD-499: Add support for ssh_config and proxycommand >> > <https://github.com/apache/libcloud/pull/226> #226 opened on Jan 20 >>2014 >> > by >> > gza >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Agz >>a >> > > >> > 1 Proof of concept API quality checking >> > <https://github.com/apache/libcloud/pull/211> #211 opened on Dec 28 >>2013 >> > by >> > Jc2k >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3AJc >>2k >> > > >> > 1 Improvements to DigitalOcean compute driver >> > <https://github.com/apache/libcloud/pull/177> #177 opened on Nov 14 >>2013 >> > by >> > mgogoulos >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Amg >>ogoulos >> > > >> > 1 [RFC] Validate SSH key format and size in the SSHKeyDeployment class >> > <https://github.com/apache/libcloud/pull/170> #170 opened on Oct 29 >>2013 >> > by >> > Kami >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3AKa >>mi >> > > >> > 1 Test LoadBalancers with a common set of tests to verify they are API >> > compliant <https://github.com/apache/libcloud/pull/135> #135 opened >>on >> > Aug >> > 18 2013 by Jc2k >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3AJc >>2k >> > > >> > 1 Change create_loadBalancer add multi port and protocol >> > <https://github.com/apache/libcloud/pull/108> #108 opened on Jun 5 >>2013 >> by >> > Gestator >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3AGe >>stator >> > > >> > 1 Update libvirt_driver.py >><https://github.com/apache/libcloud/pull/103 >> > >> > #103 >> > opened on Apr 25 2013 by fitati >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Afi >>tati >> > > >> > 1 Added support for starting a node >> > <https://github.com/apache/libcloud/pull/102> #102 opened on Apr 20 >>2013 >> > by >> > rszabo50 >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Ars >>zabo50 >> > > >> > 1 xml utf-8 workaround for python 2 >> > <https://github.com/apache/libcloud/pull/97> #97 opened on Mar 8 2013 >>by >> > gza >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3Agz >>a >> > > >> > 1 Support the use of VMWare Fusion/Workstation/Player in libcloud >> > <https://github.com/apache/libcloud/pull/82> #82 opened on Jan 4 2013 >>by >> > Jc2k >> > < >> > >> >>https://github.com/apache/libcloud/issues?q=is%3Apr+is%3Aopen+author%3AJc >>2k >> > > >> > 1 >> > [LIBCLOUD-592] Create a generic method for listing AWS EIPs >> > #334 opened on Jul 3 2014 by zerthimon 1 LIBCLOUD-590 - Reduce >>redundant >> > API calls of CloudStack compute driver's... #332 opened on Jul 1 >>2014 by >> > atsaki 1 [LIBCLOUD-588] Add ex_node_ids and ex_filters to >>list_volumes() >> > #329 >> > opened on Jun 27 2014 by zerthimon 1 [LIBCLOUD-587] >> > ex_modify_network_attributes method #328 opened on Jun 27 2014 by >> > zerthimon 1 [LIBCLOUD-586] allow EC2SecurityGroup objects be >>specified >> > when creating... #326 opened on Jun 27 2014 by zerthimon 1 >> [LIBCLOUD-540] >> > [WIP] Copy object #314 opened on Jun 11 2014 by rgbkrk 1 >>[LIBCLOUD-557] >> > Updated list_nodes to categorize private_ips and public_i... #296 >>opened >> > on May 20 2014 by sasi5a1 1 [LIBCLOUD-518] Automatically detect >>domain >> of >> > Elastic IPs. #275 opened on Apr 9 2014 by tomprince 1 restore the >> > connection request_path in case of failed request. #274 opened on >>Apr 9 >> > 2014 by mgogoulos 1 Unpack the iterator before getting its length. >>#250 >> > opened on Feb 11 2014 by coderanger 1 Cache cdn container url for >> > performance improvements #233 opened on Jan 31 2014 by jobelenus 1 >> Issue >> > LIBCLOUD-500 : support extra arguments to >> > CloudStackNodeDriver.list_nodes() #227 >> > opened on Jan 21 2014 by gza 1 Issue LIBCLOUD-499: Add support for >> > ssh_config and proxycommand #226 opened on Jan 20 2014 by gza 1 >>Proof >> of >> > concept API quality checking #211 opened on Dec 28 2013 by Jc2k 1 >> > Improvements >> > to DigitalOcean compute driver #177 opened on Nov 14 2013 by >> > mgogoulos 1 [RFC] >> > Validate SSH key format and size in the SSHKeyDeployment class #170 >> opened >> > on Oct 29 2013 by Kami 1 Test LoadBalancers with a common set of >>tests >> to >> > verify they are API compliant #135 opened on Aug 18 2013 by Jc2k 1 >> Change >> > create_loadBalancer add multi port and protocol #108 opened on Jun 5 >> 2013 >> > by Gestator 1 Update libvirt_driver.py #103 opened on Apr 25 2013 by >> > fitati 1 Added support for starting a node #102 opened on Apr 20 >>2013 >> by >> > rszabo50 1 xml utf-8 workaround for python 2 #97 opened on Mar 8 >>2013 >> by >> > gza 1 Support the use of VMWare Fusion/Workstation/Player in libcloud >> #82 >> > opened on Jan 4 2013 by Jc2k 1 >> > >> > On Mon, Nov 23, 2015 at 7:37 PM, Sebastien Goasguen <[email protected]> >> > wrote: >> > >> > > >> > > > On Nov 23, 2015, at 12:32 AM, Tomaz Muraus <[email protected]> >>wrote: >> > > > >> > > > I'm +1 for that (closing anything which is older than 6 months >>and / >> or >> > > not >> > > > relevant anymore). >> > > > >> > > > But yeah, what Jerry has said - we don't really have control over >> > Github >> > > > PRs - we can only close them using references in the commit >>message. >> > > > >> > > > One thing we could do to close them is to push a dummy commit >>which >> > > > references all the PRs which are to be closed. >> > > > >> > > >> > > Yes that¹s the way to do it, we should come up with a list of all >>this >> > PR. >> > > Ideally we can agree on this list what the PRs should be. >> > > Then push a dummy commit with Œcloses #XYZ" >> > > >> > > >> > > > On Mon, Nov 23, 2015 at 12:07 AM, anthony shaw < >> > [email protected] >> > > > >> > > > wrote: >> > > > >> > > >> Hi, >> > > >> >> > > >> I'd like to cleanup any stale PRs in the current GitHub project, >>we >> > > still >> > > >> have open one's running all the way back to 2013. >> > > >> >> > > >> I think this is largely a case that people have forgotten about >> them, >> > > >> especially ones left with failing cases. >> > > >> >> > > >> I'm proposing we give a notice to any older than 2014 saying >>this >> > will >> > > be >> > > >> closed in 30 days unless you respond. >> > > >> >> > > >> Any objections? >> > > >> >> > > >> Anthony >> > > >> >> > > >> > > >> > >>
