I believe so, yeah. Please also make sure the underline matches the title length (0.20.0 didn't have that, but it's fixed in trunk and we now have strict checking enabled).
On Fri, Jan 15, 2016 at 8:10 PM, Eric Johnson <[email protected]> wrote: > Good catch! > > While cherry-picking, the only commit I applied that had a changelog entry > was for LIBCLOUD-785. As such, does this look OK for the revised changes > file? > > diff --git a/CHANGES.rst b/CHANGES.rst > index 250869c..866962d 100644 > --- a/CHANGES.rst > +++ b/CHANGES.rst > @@ -1,6 +1,16 @@ > Changelog > ========= > > +Changes with Apache Libcloud 0.20.1 > +----------------------------------- > + > +Compute > +~~~~~~~ > + > +- [google] Allow for old and new style service account client email > address > + (LIBCLOUD-785) > + [Hoang Phan] > + > Changes with Apache Libcloud 0.20.0 > ------------------------------------------- > > @@ -30,10 +40,6 @@ General > Compute > ~~~~~~~ > > -- [google] Allow for old and new style service account client email > address > - (LIBCLOUD-785) > - [Hoang Phan] > - > - Removed DreamHosts Compute Driver, DreamHosts users will now use the > OpenStack Node driver since DreamHosts are OpenStack > API compliant > (GITHUB-655) > > > > > On Fri, Jan 15, 2016 at 10:59 AM, Tomaz Muraus <[email protected]> wrote: > > > Just noticed CHANGES.rst was not updated. > > > > Need to add new section for 0.20.1 and shuffle corresponding changelog > > entries around. > > > > When that's done you should re-tag it. > > > > On Fri, Jan 15, 2016 at 5:07 PM, Eric Johnson <[email protected]> > wrote: > > > > > This is a voting thread for Libcloud 0.20.1. > > > > > > This is a bugfix release. It consists of the following cherry-picked > > > changes in trunk applied to the 0.20.0 release ( > > > 4087f45504f7c3bbd0f389420e9ecbdedf93ded9): > > > > > > 88170f6582dd6cc3bce87c0ab3a89118551fe508 > > > - Allow for old and new style service account client email address > > (Jira > > > #785) > > > > > > 4632db2d1ee5329ab2c7421c1c5c7ee1ef1e36b4 > > > - Fix syntax error for DimensionDataStatus object (github #662) > > > > > > 2e036dae4a41b59009eb2205df4d3f1ec03beee2 > > > - Fixed bug in public IP addition command (github #661) > > > > > > f755d5597793bc8f3109f09e6b39c4ace2d740bf > > > - Fixed error when proxy_url is None > > > > > > 3e85cf1591c9ccb07ec779ccb6a589e56534799d > > > - Use hasattr rather than getattr to check for existence (github > #659) > > > > > > New 0.20.1 branch and -tentative tag are committed and can be found at > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=shortlog;h=refs/heads/0.20.1 > > > . > > > > > > Release artifacts can be found at > > > http://home.apache.org/~erjohnso/libcloud/ > > > . > > > > > > Note that KEYS file can found at > > > https://dist.apache.org/repos/dist/release/libcloud/KEYS > > > > > > Please test the release and post your votes. > > > > > > +/- 1 > > > [ ] Release Apache Libcloud 0.20.1 > > > > > > Vote will be open until January 20th, 2016 (or longer, if needed). > > > > > > (bugfix contributors have been BCC'd). > > > > > > Thanks, > > > Eric > > > > > >
